[Bug 1786397] Re: 2ping crashes on non-encrypted session

[Ubuntu Foundations Team Bug Bot]

The attachment "Fix cleanup crash on non-encrypted sessions" seems to be
a debdiff.  The ubuntu-sponsors team has been subscribed to the bug
report so that they can review and hopefully sponsor the debdiff.  If
the attachment isn't a patch, please remove the "patch" flag from the
attachment, remove the "patch" tag, and if you are member of the
~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by
~brian-murray, for any issue please contact him.]

** Tags added: patch

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1786397

Title:
  2ping crashes on non-encrypted session

Status in 2ping package in Ubuntu:
  In Progress

Bug description:
  [Impact]

   * When 2ping is being run as a non-encrypted session between two
  affected 4.1 releases, within a few minutes the client and/or server
  will crash with "TypeError: 'NoneType' object is not subscriptable" in
  scheduled_cleanup_sock_class.

   * Clients cannot sustain a 2ping session for more than a few minutes.

   * When configured as a daemon without respawn, this results in a
  denial of service. (Not default in bionic.)

   * SRU fix adds a type check for the encrypted_sessions peer table,
  which is not initialized if no encrypted packets have been received.

   * Fixed in commit 4a636763850bcea590fba6066751d13a36c2b28d
  (https://github.com/rfinnie/2ping/commit/4a636763850bcea590fba6066751d13a36c2b28d)
  and included in upstream version 4.1.2.

  [Test Case]

   * In one windows, run `2ping --listen`

   * In another, run `2ping 127.0.0.1`

   * Wait up to 5 minutes for TypeError.

  [Regression Potential]

   * SRU might not fix issue.

   * SRU fix might break scheduled cleanup of sessions when encryption
  *is* activated, leading to resource exhaustion.

   * SRU fix might break scheduled cleanup of other data unrelated to
  encryption.

   * Patch author has tested these scenarios and cannot reproduce any of
  them.

  [Other Info]
   
   * Originally reported by Github user joe1981alAPR (https://github.com/rfinnie/2ping/issues/5).

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/2ping/+bug/1786397/+subscriptions