Review Request 122777: isolate experimental cmake target from regular phonon config

Harald Sitter sitter at kde.org
Sun Jun 7 20:25:33 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122777/
-----------------------------------------------------------

(Updated June 7, 2015, 8:25 p.m.)


Status
------

This change has been marked as submitted.


Review request for Kubuntu, Phonon, Rohan Garg, Jonathan Riddell, and Sune Vuorela.


Changes
-------

Submitted with commit f9a268d386f0dcaece6232bf5c9e4b87ebc37cef by Harald Sitter to branch master.


Repository: phonon


Description
-------

This allows two things
a) One can build with experimental but not have it installed when building
   libphonon software which helps Debian.
b) A config consumer can now specify experimental as COMPONENT and force
   the phonon config to look for experimental and butt out when it can't
   find it. Whereas previously the consumer would have to check the
   variables we set to check whether experimental is even available.

Additionally we continue to quietly look for experimental when it was
built. We do now ignore if it wasn't found thus enabling our builds
to have created experimental but have it not necessarily be available at
buildtime of a consumer.

This is presenting a **slight** incompatibility in that consumers that
did previously not check our variables for whether experimental is
available (i.e. simply assumed it is always available) will now fail iff
the experimental config is not present when building the consumer.
Obviously the consumers did not necessarily build in all setups (i.e. those
without experimental) previously anyway, this is really not much of a
concern however.


Diffs
-----

  CMakeLists.txt 003e453349d61c6468d7a1111f3d95cd870cdeb7 
  PhononConfig.cmake.in 02f8b9aa29b865566536fc0fcb7a425ac09c0cfc 
  PhononExperimentalConfig.cmake.in PRE-CREATION 
  PhononExperimentalConfigVersion.cmake.in PRE-CREATION 
  phonon/experimental/CMakeLists.txt a70366490958dd89631787b1a0cf90033a93b85d 

Diff: https://git.reviewboard.kde.org/r/122777/diff/


Testing
-------

built, consumed, exploded


Thanks,

Harald Sitter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kubuntu-devel/attachments/20150607/1afbca0c/attachment.html>


More information about the kubuntu-devel mailing list