<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122777/">https://git.reviewboard.kde.org/r/122777/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Kubuntu, Phonon, Rohan Garg, Jonathan Riddell, and Sune Vuorela.</div>
<div>By Harald Sitter.</div>
<p style="color: grey;"><i>Updated June 7, 2015, 8:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit f9a268d386f0dcaece6232bf5c9e4b87ebc37cef by Harald Sitter to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
phonon
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This allows two things
a) One can build with experimental but not have it installed when building
libphonon software which helps Debian.
b) A config consumer can now specify experimental as COMPONENT and force
the phonon config to look for experimental and butt out when it can't
find it. Whereas previously the consumer would have to check the
variables we set to check whether experimental is even available.
Additionally we continue to quietly look for experimental when it was
built. We do now ignore if it wasn't found thus enabling our builds
to have created experimental but have it not necessarily be available at
buildtime of a consumer.
This is presenting a **slight** incompatibility in that consumers that
did previously not check our variables for whether experimental is
available (i.e. simply assumed it is always available) will now fail iff
the experimental config is not present when building the consumer.
Obviously the consumers did not necessarily build in all setups (i.e. those
without experimental) previously anyway, this is really not much of a
concern however.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">built, consumed, exploded</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(003e453349d61c6468d7a1111f3d95cd870cdeb7)</span></li>
<li>PhononConfig.cmake.in <span style="color: grey">(02f8b9aa29b865566536fc0fcb7a425ac09c0cfc)</span></li>
<li>PhononExperimentalConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>PhononExperimentalConfigVersion.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/experimental/CMakeLists.txt <span style="color: grey">(a70366490958dd89631787b1a0cf90033a93b85d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122777/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>