aftp:// transport is degenerated to ftp://
ghozzy at gmail.com
Thu Aug 24 14:35:55 BST 2006
On 8/24/06, Robert Collins <robertc at robertcollins.net> wrote:
> On Wed, 2006-08-23 at 13:33 -0500, John Arbash Meinel wrote:
> > Robert Collins wrote:
> > > On Tue, 2006-08-15 at 10:54 -0500, John Arbash Meinel wrote:
> > ...
> > > If there was one here, I would review it and almost certainly give you
> > > +1 as it sounds like the right approach.
> > >
> > > Cheers,
> > > Rob
> > Attached is Ghozzy's updated patch. Which looks good to me (+1)
> > It seems like a sort of bug fix that could go into 0.10, but I'll wait
> > for Robert to agree.
> > Only thing I might quibble on is whether it is worth a new test file
> > (test_aftp_transport.py) rather than just putting this into
> > test_ftp_transport.py.
> +0 from me for 0.10 and trunk.
> +1 if the test is moved into test_ftp_transport - its really not obvious
> to look for a separate file, given all the code is the ftp code.
Indeed. (why didn't i think about it myself ?)
Thanks to John for taking care of dealing with this and commiting this bit.
I'm very happy about my submitting experience here.
Thank you all for your work on this great software !
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the bazaar