aftp:// transport is degenerated to ftp://

Robert Collins robertc at robertcollins.net
Wed Aug 23 22:16:49 BST 2006


On Wed, 2006-08-23 at 13:33 -0500, John Arbash Meinel wrote:
> Robert Collins wrote:
> > On Tue, 2006-08-15 at 10:54 -0500, John Arbash Meinel wrote:
> 
> ...
> 
> > If there was one here, I would review it and almost certainly give you
> > +1 as it sounds like the right approach.
> > 
> > Cheers,
> > Rob
> 
> Attached is Ghozzy's updated patch. Which looks good to me (+1)
> 
> It seems like a sort of bug fix that could go into 0.10, but I'll wait
> for Robert to agree.
> 
> Only thing I might quibble on is whether it is worth a new test file
> (test_aftp_transport.py) rather than just putting this into
> test_ftp_transport.py.

+0 from me for 0.10 and trunk.

+1 if the test is moved into test_ftp_transport - its really not obvious
to look for a separate file, given all the code is the ftp code.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060824/614cdbff/attachment.pgp 


More information about the bazaar mailing list