On 8/24/06, <b class="gmail_sendername">Robert Collins</b> <<a href="mailto:robertc@robertcollins.net">robertc@robertcollins.net</a>> wrote:<div><span class="gmail_quote"></span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
On Wed, 2006-08-23 at 13:33 -0500, John Arbash Meinel wrote:<br>> Robert Collins wrote:<br>> > On Tue, 2006-08-15 at 10:54 -0500, John Arbash Meinel wrote:<br>><br>> ...<br>><br>> > If there was one here, I would review it and almost certainly give you
<br>> > +1 as it sounds like the right approach.<br>> ><br>> > Cheers,<br>> > Rob<br>><br>> Attached is Ghozzy's updated patch. Which looks good to me (+1)<br>><br>> It seems like a sort of bug fix that could go into
0.10, but I'll wait<br>> for Robert to agree.<br>><br>> Only thing I might quibble on is whether it is worth a new test file<br>> (test_aftp_transport.py) rather than just putting this into<br>> test_ftp_transport.py.
<br><br>+0 from me for 0.10 and trunk.<br><br>+1 if the test is moved into test_ftp_transport - its really not obvious<br>to look for a separate file, given all the code is the ftp code.<br><br>-Rob<br></blockquote></div>
<br>
Indeed. (why didn't i think about it myself ?)<br>
Thanks to John for taking care of dealing with this and commiting this bit.<br>
I'm very happy about my submitting experience here.<br>
Thank you all for your work on this great software !<br>
<br>
--<br>
ghozzy<br>