[apparmor] [patch] Ignore test failures about duplicated conditionals in dbus rules
tyhicks at canonical.com
Thu Apr 20 19:23:55 UTC 2017
On 04/15/2017 05:54 PM, Christian Boltz wrote:
> Any comments or reviews on this patch?
> If nobody objects, I'll commit it (to trunk and 2.11) on Wednesday as
> Acked-by <timeout>.
I see that the review period timed out already. That's fine by me as the
change looks correct. Sorry that nobody could do a review in time.
> Am Samstag, 25. März 2017, 21:53:21 CEST schrieb Christian Boltz:
>> since r3634, the tools allow any order of dbus conditionals.
>> Quoting the r3634 patch description:
>> This patch eases the restriction on the ordering at the expense of
>> the utils no longer being able to detect and reject a single
>> attribute that is repeated multiple times. In that situation, only
>> the last occurrence of the attribute will be honored by the utils.
>> It seems nobody tested with all test profiles generated ;-) so we have
>> to add some exceptions to the "does not raise an exception" list now.
There was a typo in my build/test script that caused these tests to be
missed. I've just fixed my script.
Is there a good reason for the utils `make check` target to pass even if
all the parser test profiles haven't been generated? If there's no good
reason, could you update the tests to fail in that situation? A make
variable could be added to indicate this this condition should be
ignored so that you can quickly iterate on utils changes without needing
all of the generated profiles.
>> [ 01-parser-tests-dbus-duplicated-conditionals.diff ]
>> === modified file 'utils/test/test-parser-simple-tests.py'
>> --- utils/test/test-parser-simple-tests.py 2017-03-03 12:14:03
>> +0000 +++ utils/test/test-parser-simple-tests.py 2017-03-25
>> 20:45:42 +0000 @@ -49,6 +49,15 @@
>> + # duplicated conditionals aren't detected by the tools
>> + 'generated_dbus/duplicated-conditionals-45127.sd',
>> + 'generated_dbus/duplicated-conditionals-45131.sd',
>> + 'generated_dbus/duplicated-conditionals-45124.sd',
>> + 'generated_dbus/duplicated-conditionals-45130.sd',
>> + 'generated_dbus/duplicated-conditionals-45125.sd',
>> + 'generated_dbus/duplicated-conditionals-45128.sd',
>> + 'generated_dbus/duplicated-conditionals-45129.sd',
> Christian Boltz
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 801 bytes
Desc: OpenPGP digital signature
More information about the AppArmor