[apparmor] [patch] Ignore test failures about duplicated conditionals in dbus rules

[Christian Boltz]

Hello,

Any comments or reviews on this patch?

If nobody objects, I'll commit it (to trunk and 2.11) on Wednesday as 
Acked-by <timeout>.

Am Samstag, 25. März 2017, 21:53:21 CEST schrieb Christian Boltz:
> since r3634, the tools allow any order of dbus conditionals.
> 
> Quoting the r3634 patch description:
> 
>   This patch eases the restriction on the ordering at the expense of
> the utils no longer being able to detect and reject a single
> attribute that is repeated multiple times. In that situation, only
> the last occurrence of the attribute will be honored by the utils.
> 
> It seems nobody tested with all test profiles generated ;-) so we have
> to add some exceptions to the "does not raise an exception" list now.
> 
> 
> [ 01-parser-tests-dbus-duplicated-conditionals.diff ]
> 
> === modified file 'utils/test/test-parser-simple-tests.py'
> --- utils/test/test-parser-simple-tests.py      2017-03-03 12:14:03
> +0000 +++ utils/test/test-parser-simple-tests.py      2017-03-25
> 20:45:42 +0000 @@ -49,6 +49,15 @@
>      'change_profile/onx_conflict_unsafe1.sd',
>      'change_profile/onx_conflict_unsafe2.sd',
> 
> +    # duplicated conditionals aren't detected by the tools
> +    'generated_dbus/duplicated-conditionals-45127.sd',
> +    'generated_dbus/duplicated-conditionals-45131.sd',
> +    'generated_dbus/duplicated-conditionals-45124.sd',
> +    'generated_dbus/duplicated-conditionals-45130.sd',
> +    'generated_dbus/duplicated-conditionals-45125.sd',
> +    'generated_dbus/duplicated-conditionals-45128.sd',
> +    'generated_dbus/duplicated-conditionals-45129.sd',
> +
>      'dbus/bad_modifier_2.sd',
>      'dbus/bad_regex_01.sd',
>      'dbus/bad_regex_02.sd',



Regards,

Christian Boltz
-- 
systemd is the worst thing I have seen in ten years with
SuSE distributions, comparable perhaps only with zmd.
[Michal Kubecek in https://bugzilla.novell.com/725917#c38]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20170416/1be1e87b/attachment.pgp>