Ubiquity plugins review

[Mario Limonciello]

Hi Mike:

On Tue, Aug 25, 2009 at 23:09, Michael Terry <michael.terry at canonical.com>wrote:

> On Tue, 2009-08-25 at 15:32 +0100, Evan Dandrea wrote:
> > Having a ordering system codified in a prefix of the filenames strikes
> > me as making the tree look a bit more complicated than it is.
> > Personally, I would add a WEIGHT field alongside BEFORE and AFTER, but
> > I'm fine with the way you've approached the problem.
>
> My branch is converted to WEIGHT.  The plugin filenames are much more
> understandable now, and order resolution is more intuitive.  Thanks for
> the idea.
>
>
> > There's a slight typo at the bottom of the console_setup and timezone
> > plugins.  It should be InstallPlugin.install(self, target, ...)
> >
> > import usersetup_apply is missing from scripts/install.py and
> > self.get_language needs to be replaced with self.locale.split('_')[0]
> > in kde_ui.
>
> All fixed in my branch.
>
> -mt
>

Given my short amount of time looking at this, I gave this a brief look over
the code and a local test build to test the mythbuntu frontend now.  It
looks like for the most part it's working properly with the exception of
that last page. It's intended to be presented after the install finishes,
but it's coming up before you press the "Install" button.

-- 
Mario Limonciello
superm1 at gmail.com
Sent from Manchester, New Hampshire, United States
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ubuntu.com/archives/ubuntu-installer/attachments/20090826/0910cc47/attachment-0001.htm