NACK: [SRU][B][X][PATCH 1/1] UBUNTU: SAUCE: selftest: rtctest: Force passing unreliable subtest

[Andrei Gherzan]

On Mon, 20 Feb 2023 at 12:28, Andrei Gherzan <andrei.gherzan at canonical.com>
wrote:

> BugLink: https://bugs.launchpad.net/bugs/1814234


Self-NACK-ed as per a typo in the BugLink (in the 1/1 patch). I will follow
up with a v2.


>
>
> Since 0b63accf87225b5eb7e52814c374cf02d733d4bb, the test includes a
> verification of time passage that is unstable as it is prone to
> different results based on the system load.
>
> Other investigations led to disabling this test in various other
> places/projects. For example, Linaro also disabled it[1].
>
> We have chosen to keep this test but to force its result unconditionally
> successful as opposed to reverting the aforementioned commit because:
> 1. it keeps running the test with results and data that we can use in
>    the future for any "smarter" way to deal with it - eg. statistical
>    approach
> 2. it minimizes the maintenance burden of this patch kept in our kernel
>    trees
>
> It is worth mentioning that upstream was contacted via the mailing list
> with no feedback[2]. The request was to increase the current tolerance
> set at 10%.
>
> [1] https://bugs.linaro.org/show_bug.cgi?id=3402#c9
> [2]
> https://lore.kernel.org/lkml/a304b6f1-11db-543b-2cb3-372f34dc7697@linaro.org/
>
> Signed-off-by: Andrei Gherzan <andrei.gherzan at canonical.com>
> ---
>  tools/testing/selftests/timers/rtctest.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/timers/rtctest.c
> b/tools/testing/selftests/timers/rtctest.c
> index 411eff625e66d..6166ff7b022ba 100644
> --- a/tools/testing/selftests/timers/rtctest.c
> +++ b/tools/testing/selftests/timers/rtctest.c
> @@ -319,10 +319,11 @@ int main(int argc, char **argv)
>                         if (diff.tv_sec > 0 ||
>                             diff.tv_usec > ((1000000L / tmp) * 1.10)) {
>                                 fprintf(stderr, "\nPIE delta error:
> %ld.%06ld should be close to 0.%06ld\n",
> +                               fprintf(stderr, "\nUbuntu Testing Force
> Pass LP #1814234: PIE delta error: %ld.%06ld should be close to 0.%06ld\n",
>                                        diff.tv_sec, diff.tv_usec,
>                                        (1000000L / tmp));
>                                 fflush(stdout);
> -                               exit(-1);
> +                               break; // LP: #1814234
>                         }
>
>                         fprintf(stderr, " %d",i);
> --
> 2.34.1
>
>

-- 
Andrei Gherzan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230220/033c505c/attachment-0001.html>