NACK: [SRU][L/unstable][L][K][J][J/oem-5.17][J/oem-6.0][J/oem-6.1][F][F/oem-5.14]PATCH 0/1] Force-pass the passage of time test in rtcpie

Andrei Gherzan andrei.gherzan at canonical.com
Mon Feb 20 12:41:26 UTC 2023


On Mon, 20 Feb 2023 at 12:29, Andrei Gherzan <andrei.gherzan at canonical.com>
wrote:

> Buglink: https://bugs.launchpad.net/bugs/1881096
>
>
Self-NACK-ed as per a typo in the BugLink. I will follow up with a v2.


> SRU Justification:
>
> [Impact]
>
> * This test can fail selftest on various test hosts in our testing
>   infrastructure forcing us to keep hinting releases. This leads to
>   maintenance burden for a test that is unreliable as it depends on the
>   context of the running host.
>
> [Fix]
>
> * Force-pass the test included by upstream in
>   0b63accf87225b5eb7e52814c374cf02d733d4bb. We have chosen to keep this
>   test but to force its result unconditionally successful as opposed to
>   reverting the aforementioned commit because:
>   1. it keeps running the test with results and data that we can use in
>      the future for any "smarter" way to deal with it - eg. statistical
>      approach
>   2. it minimizes the maintenance burden of this patch kept in our
>      kernel trees
>
> [Test Plan]
>
> * It was tested in clean VMs.
>
> [Where problems could occur]
>
> * No regression expected and the scope is in this specific selftest.
>
> Andrei Gherzan (1):
>   UBUNTU: SAUCE: selftest: rtcpie: Force passing unreliable subtest
>
>  tools/testing/selftests/timers/rtcpie.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> --
> 2.34.1
>
>

-- 
Andrei Gherzan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230220/6bb0dd35/attachment.html>


More information about the kernel-team mailing list