<div dir="ltr"><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 20 Feb 2023 at 12:28, Andrei Gherzan <<a href="mailto:andrei.gherzan@canonical.com" target="_blank">andrei.gherzan@canonical.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">BugLink: <a href="https://bugs.launchpad.net/bugs/1814234" rel="noreferrer" target="_blank">https://bugs.launchpad.net/bugs/1814234</a></blockquote><div> </div><div><div>Self-NACK-ed as per a typo in the BugLink (in the 1/1 patch). I will follow up with a v2.</div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
<br>
Since 0b63accf87225b5eb7e52814c374cf02d733d4bb, the test includes a<br>
verification of time passage that is unstable as it is prone to<br>
different results based on the system load.<br>
<br>
Other investigations led to disabling this test in various other<br>
places/projects. For example, Linaro also disabled it[1].<br>
<br>
We have chosen to keep this test but to force its result unconditionally<br>
successful as opposed to reverting the aforementioned commit because:<br>
1. it keeps running the test with results and data that we can use in<br>
   the future for any "smarter" way to deal with it - eg. statistical<br>
   approach<br>
2. it minimizes the maintenance burden of this patch kept in our kernel<br>
   trees<br>
<br>
It is worth mentioning that upstream was contacted via the mailing list<br>
with no feedback[2]. The request was to increase the current tolerance<br>
set at 10%.<br>
<br>
[1] <a href="https://bugs.linaro.org/show_bug.cgi?id=3402#c9" rel="noreferrer" target="_blank">https://bugs.linaro.org/show_bug.cgi?id=3402#c9</a><br>
[2] <a href="https://lore.kernel.org/lkml/a304b6f1-11db-543b-2cb3-372f34dc7697@linaro.org/" rel="noreferrer" target="_blank">https://lore.kernel.org/lkml/a304b6f1-11db-543b-2cb3-372f34dc7697@linaro.org/</a><br>
<br>
Signed-off-by: Andrei Gherzan <<a href="mailto:andrei.gherzan@canonical.com" target="_blank">andrei.gherzan@canonical.com</a>><br>
---<br>
 tools/testing/selftests/timers/rtctest.c | 3 ++-<br>
 1 file changed, 2 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/tools/testing/selftests/timers/rtctest.c b/tools/testing/selftests/timers/rtctest.c<br>
index 411eff625e66d..6166ff7b022ba 100644<br>
--- a/tools/testing/selftests/timers/rtctest.c<br>
+++ b/tools/testing/selftests/timers/rtctest.c<br>
@@ -319,10 +319,11 @@ int main(int argc, char **argv)<br>
                        if (diff.tv_sec > 0 ||<br>
                            diff.tv_usec > ((1000000L / tmp) * 1.10)) {<br>
                                fprintf(stderr, "\nPIE delta error: %ld.%06ld should be close to 0.%06ld\n",<br>
+                               fprintf(stderr, "\nUbuntu Testing Force Pass LP #1814234: PIE delta error: %ld.%06ld should be close to 0.%06ld\n",<br>
                                       diff.tv_sec, diff.tv_usec,<br>
                                       (1000000L / tmp));<br>
                                fflush(stdout);<br>
-                               exit(-1);<br>
+                               break; // LP: #1814234<br>
                        }<br>
<br>
                        fprintf(stderr, " %d",i);<br>
-- <br>
2.34.1<br>
<br>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr"><div dir="ltr"><div><span style="color:rgb(34,34,34)">Andrei Gherzan</span><br></div></div></div></div>