[Acked/CMT] [PATCH 0/4][linux-signed*] Correct source package in Built-Using control field

[Stefan Bader]

On 10.04.19 10:10, Andy Whitcroft wrote:
> On Tue, Apr 09, 2019 at 03:24:50PM -0600, dann frazier wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1824016
>>
>> The Built-Using field hardcodes "linux" as the source package, even for the
>> hwe & hwe-edge packages. Correct that. Technically only the
>> linux-signed-hwe{-edge} packages need this fix, but I'm including patches
>> for linux-signed as well to prevent future occurences due to cargo-culting.
> 
> These look sane enough.  I think PACKAGE is a terrible name as which
> package is that, yes it happens to be the parent, but that is really not
> clear.  Could we call it something else?  We use SRCPKGNAME for 'our'
> package name in linux itself.  BUPKGNAME would fit in _that_ horrible
> naming scheme.  Perhaps BUILT_USING_PACKAGE ?
> 
> Also we must have this problem in more -signed packages than are
> included in this set, we should have a review across all our -signeds.
> 
> With a sane name chosen:
> 
> Acked-by: Andy Whitcroft <apw at canonical.com>

That sounds to me like we should for now hold back on touching older series and
get a fully blessed version into disco and then re-submit for c/b/x with any
additional changes needed.

-Stefan
> 
> -apw
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20190410/8aeaed9a/attachment.sig>