[Acked/CMT] [PATCH 0/4][linux-signed*] Correct source package in Built-Using control field

[dann frazier]

On Wed, Apr 10, 2019 at 09:10:59AM +0100, Andy Whitcroft wrote:
> On Tue, Apr 09, 2019 at 03:24:50PM -0600, dann frazier wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1824016
> > 
> > The Built-Using field hardcodes "linux" as the source package, even for the
> > hwe & hwe-edge packages. Correct that. Technically only the
> > linux-signed-hwe{-edge} packages need this fix, but I'm including patches
> > for linux-signed as well to prevent future occurences due to cargo-culting.
> 
> These look sane enough.  I think PACKAGE is a terrible name as which
> package is that, yes it happens to be the parent, but that is really not
> clear.  Could we call it something else?  We use SRCPKGNAME for 'our'
> package name in linux itself.  BUPKGNAME would fit in _that_ horrible
> naming scheme.

Thanks for reviewing.

I used PACKAGE for consistency w/ "ABI" and the equally incoherent
"VERSION". I think if we use something else for PACKAGE - and I agree
we should - we should also rename "VERSION".

> Perhaps BUILT_USING_PACKAGE ?

That would imply my renamed VERSION would become BUILT_USING_VERSION,
but then we'd end up with:
 Build-Depends-Arch: linux-libc-dev (>= BUILT_USING_VERSION)

Which I don't really like, since BUILT_USING suggests it'd only be used
in the Built-Using field. What about UNSIGNED_SRC_{PACKAGE,VERSION}
instead? I'll try that out for v2 if no one objects before.

> Also we must have this problem in more -signed packages than are
> included in this set, we should have a review across all our -signeds.

On Wed, Apr 10, 2019 at 2:47 AM Stefan Bader <stefan.bader at canonical.com> wrote:
> That sounds to me like we should for now hold back on touching older
> series and get a fully blessed version into disco and then re-submit
> for c/b/x with any additional changes needed.

Agreed. I'll submit a v2 for just linux-signed/disco and, once we have
an agreement on the macro style, we can use it as a template for the
other packages, then move it back to other series.

  -dann