[Review Queue] nrpe

[Adam Israel]

        nrpe:

This is a rewrite of the trusty nrpe charm, which includes
nrpe-external-master functionality, using the services framework. There
are a few other merge proposals blocked due to the lack of a
nrpe-external-master relation in trusty, so this will be a welcome
addition to the charm store.

I ran into a few minor issues with the charm’s tests. It’s attempting to
lint a non-existent directory, and it’s |make test| is failing when run
from bundletester. The addition of a |tests.yaml| in the test directory,
to specifically run only the lint target, will allow bundletester to
auto-detect the tests to run.

I also discovered, and submitted a pull request for, a bug in
bundletester 0.5.1, that could cause |make lint| and |make test| from
being run multiple times, and would always run lint or test regardless
of the |tests.yaml| makefile setting.

​
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20150325/cb76bcb1/attachment.html>