Is ReviewBoard a good thing?

Eric Snow eric.snow at canonical.com
Fri Sep 19 15:02:54 UTC 2014


On Thu, Sep 18, 2014 at 6:32 PM, David Cheney
<david.cheney at canonical.com> wrote:
> There were three problem reviewboard was supposed to address, review
> comments are sent immediately, no side by side diffs, and no way to to
> chained proposals.

It will be worth being extra clear on ReviewBoard's pros and cons.
I'll open a new thread.

>
> I think that over the last few months we've all learnt to live with
> the first issue

I for one haven't.  On several occasions I have made a comment that I
later realized was not valid, but am not able to simply remove since
it already sent.

>
> On the second, github now does nice side by side diffs.

Agreed.

>
> On the third, it appears reviewboard leaves you solidly to your own
> devices to implement chained proposals.

rbt supports it just fine and reviewboard itself supports it (see the
"Depends on" field on every review request).  What support did you
have in mind?

-eric



More information about the Juju-dev mailing list