Is ReviewBoard a good thing?

[David Cheney]

On Sat, Sep 20, 2014 at 1:02 AM, Eric Snow <eric.snow at canonical.com> wrote:
> On Thu, Sep 18, 2014 at 6:32 PM, David Cheney
> <david.cheney at canonical.com> wrote:
>> There were three problem reviewboard was supposed to address, review
>> comments are sent immediately, no side by side diffs, and no way to to
>> chained proposals.
>
> It will be worth being extra clear on ReviewBoard's pros and cons.
> I'll open a new thread.
>
>>
>> I think that over the last few months we've all learnt to live with
>> the first issue
>
> I for one haven't.  On several occasions I have made a comment that I
> later realized was not valid, but am not able to simply remove since
> it already sent.
>
>>
>> On the second, github now does nice side by side diffs.
>
> Agreed.
>
>>
>> On the third, it appears reviewboard leaves you solidly to your own
>> devices to implement chained proposals.
>
> rbt supports it just fine and reviewboard itself supports it (see the
> "Depends on" field on every review request).  What support did you
> have in mind?

Ian and Tim want whatever they had with launchpad. I never used lp
like that so I never felt the loss; I just propose one branch at a
time and have others waiting in the wings that I can propose as soon
as the predecessor lands.

>
> -eric