PyPy and bzr

[Jelmer Vernooij]

On Sat, 2011-05-14 at 02:49 +0900, INADA Naoki wrote:
> One thing I found is that bzrlib.export.tgz_exporter depends on CPython's
> refcount behavior.
> It opens a file and pass to gzip.GZipFile, then pass it to tarfile.open.
> gzip.GZipFile.close() doesn't close passed stream and tarball.close() also.
> So we should close the file explicitly.
Can you send a patch or file a bug about this? I think this would be a
nice thing to fix, as it gets us closer to PyPy compatibility but also is just
more correct to do in the first place.

Thanks for looking into PyPy support btw, I think it would be a really
interesting feature to have.

Cheers,

Jelmer

> On Fri, May 13, 2011 at 5:46 PM, Martin Pool <mbp at canonical.com> wrote:
> > On 13 May 2011 02:45, INADA Naoki <songofacandy at gmail.com> wrote:
> >> Attached file is result of pypy ./bzr --no-plugins sefltest.
> >> It's less than 1000 lines.
> >> And CPython also have some errors on my environment.
> >
> > Wow, that's pretty good, only about eight underlying errors it seems,
> > and some of them are probably shallow things like different error
> > classes being raised.  I would love to see it clean; just ask if you
> > want to brainstorm why any of them are failing.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <https://lists.ubuntu.com/archives/bazaar/attachments/20110513/49f44541/attachment-0001.pgp>