PyPy and bzr

[INADA Naoki]

bzrlib.tests.test_pack.TestPack._update_pack doesn't close a file
explicitly too.

On Sat, May 14, 2011 at 2:49 AM, INADA Naoki <songofacandy at gmail.com> wrote:
> One thing I found is that bzrlib.export.tgz_exporter depends on CPython's
> refcount behavior.
> It opens a file and pass to gzip.GZipFile, then pass it to tarfile.open.
> gzip.GZipFile.close() doesn't close passed stream and tarball.close() also.
> So we should close the file explicitly.
>
> On Fri, May 13, 2011 at 5:46 PM, Martin Pool <mbp at canonical.com> wrote:
>> On 13 May 2011 02:45, INADA Naoki <songofacandy at gmail.com> wrote:
>>> Attached file is result of pypy ./bzr --no-plugins sefltest.
>>> It's less than 1000 lines.
>>> And CPython also have some errors on my environment.
>>
>> Wow, that's pretty good, only about eight underlying errors it seems,
>> and some of them are probably shallow things like different error
>> classes being raised.  I would love to see it clean; just ask if you
>> want to brainstorm why any of them are failing.
>>
>> Martin
>>
>
>
>
> --
> INADA Naoki  <songofacandy at gmail.com>
>



-- 
INADA Naoki  <songofacandy at gmail.com>