[RFC] I want to disable submit_branch on my computer for all branches. How can I do that?

[Martin Pool]

On 13 May 2011 16:18, Aaron Bentley <aaron at aaronbentley.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 11-05-13 04:00 AM, vila wrote:
>> But this is precisely what Alexander (and others including me) is
>> complaining about (and I don't understand the use case it's addressing,
>> if the user is explicit about his desire (--no-remember specified last),
>> we should respect it).
>
> We should definitely respect the user's desire, but the "--no-" options
> exist to force bzr to give use the default behaviour.  So when a user
> uses one, their desire is to restore the default behaviour.  It's not
> "don't remember", it's "ignore the fact that I specified --remember".
> This applies to all out boolean options, and it's there so that users
> can alias commands to get non-default behaviour and still have a way to
> restore default behaviour.  For example, I have "commit" aliased to
> "commit --strict".  This does what I want 95% of the time, and the rest
> of the time, I use commit --no-strict to restore the default behaviour.

You're quite right that --no-foo ought mean "forget I specified foo"
if it's off by default, not something different.  The problem is that
we have three reasonable settings:
1 - don't remember it
2 - remember it if it's not set, otherwise don't (current default)
3 - remember it unconditionally (current --remember)

Making --no-remember take you back to #2 would be consistent with the
current option, but also probably not what people normally want.  I
think the default, and (therefore) the behaviour of --no-remember
ought to be #1.

>> - change the default behavior to respect user input.
>
> I find it very frustrating that you are asserting that the current
> behaviour does not respect user input.  When the user specifies it, it
> does something.  That's respecting user input.
>
> It doesn't do what *you* expect, but I believe that's based on a
> misunderstanding of what it's supposed to do.

Vincent's summary was pretty vague and almost a truism, but I think I
know what he meant.

Martin