[RFC] I want to disable submit_branch on my computer for all branches. How can I do that?

[vila]

>>>>> Aaron Bentley <aaron at aaronbentley.com> writes:

    > On 11-05-13 04:00 AM, vila wrote:
    >> But this is precisely what Alexander (and others including me) is
    >> complaining about (and I don't understand the use case it's addressing,
    >> if the user is explicit about his desire (--no-remember specified last),
    >> we should respect it).

    > We should definitely respect the user's desire, but the "--no-" options
    > exist to force bzr to give use the default behaviour.

Hmm, that's part of the discussion I think.

To me, -no applies to a boolean and is meant to reverse it. The point
here is that --remember as it is implemented is not related to the fact
that the setting is remembered if it doesn't exist.

    > So when a user uses one, their desire is to restore the default
    > behaviour.  It's not "don't remember", it's "ignore the fact that
    > I specified --remember".

Well, I think that's another part of the disagreement, the default
behavior is to remember the setting, *BUT* the default value of the
remember parameter is False !

Hence Martin's proposal to add another option to govern the default
behavior.

If the command switch was called --override, it would make more sense
and be easier to understand for the user. Discovering 'remember=False'
in cmd_merge is not for the average user.

    > This applies to all out boolean options, and it's there so that
    > users can alias commands to get non-default behaviour and still
    > have a way to restore default behaviour.

That's still true for all options which govern a behavior that depend
solely on the option itself. That's not the case here since this also
depends on the existence of the option.

    > For example, I have "commit" aliased to "commit --strict".  This
    > does what I want 95% of the time, and the rest of the time, I use
    > commit --no-strict to restore the default behaviour.

Yup, this matches my description above.

    >> - change the default behavior to respect user input.

    > I find it very frustrating

Well, I'm sorry about that, that wasn't my intent, I hope we can still
discuss the issue anyway.

    > that you are asserting that the current behaviour does not respect
    > user input.  When the user specifies it, it does something.
    > That's respecting user input.

Well, s/input/expectations/ if you prefer, but the point was that some
users want to be able to *not* set 'submit_branch' and it seem more
common to not set 'submit_branch' than to use 'merge --remember
--no-remember' (and I still miss how it's useful in this context).

In the end, there are people that want to set it and people that don't.
Keeping the actual behavior doesn't address the needs of the later, as
Alexander said when starting this thread:

   bzr merge --no-remember ../xxx

just does not what one expect it to do, you could argue that
--no-remember doesn't mean "don't remember", that's still hard to
swallow...

        Vincent

P.S.: Again, I didn't mean to offense anyone, keep in mind that I'm not
a native speaker when you feel I offend you. I just don't like to offend
people, it's just counter-productive.