[RFC] I want to disable submit_branch on my computer for all branches. How can I do that?

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11-05-12 04:43 PM, vila wrote:
>>>>>> Aaron Bentley <aaron at aaronbentley.com> writes:

>     > You can say that, but it's doing exactly what you'd expect: --remember
>     > overrides the default behaviour,
> 
> Err, --remember , to me, means takes this new setting as the one you
> should remember.

Right, you're overriding the default behaviour, and the new behaviour is
to take this new setting as the one your should remember.

> If I don't use it, it just keeps the old one and don't try to remember
> the one I'm using now.

No, that's not true.  The default behaviour is:
If the user specifies a location, and if no location is currently
configured, remember the location.

> So --no-remember should just use the setting without remembering
> it.

No, that would only be true if the default behaviour were to never
remember the location.

> You mean that the default behaviour is to remember if nothing is set :)

Yes, assuming the user specified a path.

> But frankly, this is rather surprising no ?

It's how --remember behaves everywhere AFAIK.

> --no-remember still
> remembers when nothing has been remembered before... 

Perhaps, but it's consistent with all our other --no- options.
Inconsistency is also confusing.

> You're really trying to trigger my Alzheimer aren't you ?
> 
> Looks like we can't put more than two values into a boolean are we ?

No, but we can switch to a RegistryOption and have --remember,
- --maybe-remember and --never-remember.

> Let's see:
> 
> no exiting setting:
> * default: current setting is stored,
> * --remember: current setting is stored,
> * --no-remember: current setting is not stored
> 
> existing setting:
> * default: current setting is *not* stored,
> * --remember: current setting is stored
> * --no-remember: current setting is not stored
> 
> Yes, I cheated, I used None, True, False, thanks python :)
> 
> Does that work for you ?

I don't like it, because it breaks "merge --remember --no-remember" when
there's no existing setting.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk3MS0AACgkQ0F+nu1YWqI3RCACePDR/eJNYAUhk01mcrPzcY14N
yKEAnjtQ89YzmPrrTt1UbUifo1F4ZgMW
=DCh9
-----END PGP SIGNATURE-----