Not resubmitting almost as confusing for reviewing

Aaron Bentley aaron at aaronbentley.com
Mon Dec 21 19:15:21 GMT 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> So our current policy of not using the 'resubmit' button does cause some
> confusion (for me) when doing reviews that take a round-trip or two.
> 
> Specifically, if I look at +activereviews, then I can see what things
> need to be reviewed, and "reviews I am doing". However the I am doing
> category confuses me a bit. Specifically, Neil recently sent in
> https://code.edge.launchpad.net/~nmb/bzr/switch-uses-directories/+merge/16024
> 
> On my +activereviews page it looks like it has been reviewed, and still
> has 2 'needsfixing' comments.

You can mark legitimate cases of this as "work in progress", so they
won't appear in your "reviews I am doing" list.

> I guess what I'm looking for is a "reset the active votes on this merge
> proposal since they should have been addressed", without losing the
> existing commentary so that future reviewers can see the requests, and
> make sure they were actually handled.
> 
> Thoughts?

Sounds a lot like what we have planned for resubmit.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAksvyUUACgkQ0F+nu1YWqI0kvACfRPXappMW3NdcPYCVS0hqzN6v
NDEAnRZdVQwt2nOtwR2F6/n75is4+CBs
=BvH6
-----END PGP SIGNATURE-----



More information about the bazaar mailing list