Not resubmitting almost as confusing for reviewing
John Arbash Meinel
john at arbash-meinel.com
Mon Dec 21 19:16:46 GMT 2009
-----BEGIN PGP SIGNED MESSAGE-----
Aaron Bentley wrote:
> John Arbash Meinel wrote:
>> So our current policy of not using the 'resubmit' button does cause some
>> confusion (for me) when doing reviews that take a round-trip or two.
>> Specifically, if I look at +activereviews, then I can see what things
>> need to be reviewed, and "reviews I am doing". However the I am doing
>> category confuses me a bit. Specifically, Neil recently sent in
>> On my +activereviews page it looks like it has been reviewed, and still
>> has 2 'needsfixing' comments.
> You can mark legitimate cases of this as "work in progress", so they
> won't appear in your "reviews I am doing" list.
Sure, but when NMB marks it as "Needs Review" again, it goes back and
looks like it has already been reviewed.
>> I guess what I'm looking for is a "reset the active votes on this merge
>> proposal since they should have been addressed", without losing the
>> existing commentary so that future reviewers can see the requests, and
>> make sure they were actually handled.
> Sounds a lot like what we have planned for resubmit.
Which sounds like what I want :).
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----
More information about the bazaar