Not resubmitting almost as confusing for reviewing

John Arbash Meinel john at arbash-meinel.com
Mon Dec 21 17:31:10 GMT 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

So our current policy of not using the 'resubmit' button does cause some
confusion (for me) when doing reviews that take a round-trip or two.

Specifically, if I look at +activereviews, then I can see what things
need to be reviewed, and "reviews I am doing". However the I am doing
category confuses me a bit. Specifically, Neil recently sent in
https://code.edge.launchpad.net/~nmb/bzr/switch-uses-directories/+merge/16024

On my +activereviews page it looks like it has been reviewed, and still
has 2 'needsfixing' comments. That makes me initially think that I
should just skip over that one. However, he has addressed both needs
fixing comments.

I guess what I'm looking for is a "reset the active votes on this merge
proposal since they should have been addressed", without losing the
existing commentary so that future reviewers can see the requests, and
make sure they were actually handled.

Thoughts?

This certainly could just be a bug in how I perceive the page, or how we
are using it. (We currently have quite a few entries in the "I am doing"
and "I am *not* doing", and it is unclear with what priority those
should be addressed.)

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAksvsN4ACgkQJdeBCYSNAAONEQCgmsaTdJ7mxpLNRyC3Fz3I3aS0
sTAAoK89Y9b5VJ1qC2MZ4mMJgDINmKTb
=dD3V
-----END PGP SIGNATURE-----



More information about the bazaar mailing list