Bug 425510 & Bug 426410 (shell completion on win32)

[Maritza Mendez]

Sneaky keyboard shortcuts... I sent the email by typing too fast...  As I
was saying...

I have pushed tests based on Vincent's miraculous shell-like tests facility
[1] to lp:~martitzam/bzr/win32-wildcards

I have *not* pushed fixes for these bugs yet.  Tests first.

Both tests pass on karmic and fail on win32 as you would expect from the bug
reports.

I welcome feedback on everything, including especially

* how I set up my branch on lp
* the location of the tests [2]
* the tests themselves

And I offer the following observations:

* notice that the output of 'bzr rm' is written to stderr instead of
stdout.  Realizing hat is what took me the longest time!
* since the order of output lines could theoreticaly change in a future
release of bzr without affecting the validity of the tests, I was tempted to
use '...' in the output matching.  But I decided to go with the exact
output, since ... is too big a "hole" for these tests.  But thsi is brittle
wrt future releases which may change output order.  Ideally, we would have
some regexp-by-line capability which would say "the output must contain all
of these lines but in any order."  I know I could accomplish this by piping
the output of bzr to sort and grep, but that makes the tests hard to read
and besides I am lazy.  :)

Also, a huge thank you to everyone who is providing guidance to me on these
bugs, especially Vincent for the shell-like tests.

Next step: get feedback and then implement the (trivial) fixes for these
bugs and repeat tests on karmic and win32.

~M

[1] I was able to get up and running with just a few hints from Vincent.  It
literally took me less than an hour to create two tests, and this was my
first time creating *any* test for bzr.

[2] I have tentatively left the tests among the unittests, even though they
*seem* like they belong with the blackbox tests.  I did this because the bb
tests seem to be command-specific (as strongly suggested in
doc/developers/testing.txt) and I wanted to keep the wildcard matching tests
all together in one place for now.  I'm open to improvements, naturally.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ubuntu.com/archives/bazaar/attachments/20091104/c6d5cdab/attachment.htm