<br>Sneaky keyboard shortcuts... I sent the email by typing too fast... As I was saying...<br><div> <br>I have pushed tests based on Vincent's miraculous shell-like tests facility [1] to lp:~martitzam/bzr/win32-wildcards<br>
<br></div>I have <b>not</b> pushed fixes for these bugs yet. Tests first. <br><br>Both tests pass on karmic and fail on win32 as you would expect from the bug reports.<br>
<br>I welcome feedback on everything, including especially<br><br>* how I set up my branch on lp<br>* the location of the tests [2]<br>* the tests themselves<br><br>And I offer the following observations:<br><br>* notice that the output of 'bzr rm' is written to stderr instead of stdout. Realizing hat is what took me the longest time!<br>
* since the order of output lines could theoreticaly change in a future release of bzr without affecting the validity of the tests, I was tempted to use '...' in the output matching. But I decided to go with the exact output, since ... is too big a "hole" for these tests. But thsi is brittle wrt future releases which may change output order. Ideally, we would have some regexp-by-line capability which would say "the output must contain all of these lines but in any order." I know I could accomplish this by piping the output of bzr to sort and grep, but that makes the tests hard to read and besides I am lazy. :)<br>
<br>Also, a huge thank you to everyone who is providing guidance to me on these bugs, especially Vincent for the shell-like tests.<br><br>Next step: get feedback and then implement the (trivial) fixes for these bugs and repeat tests on karmic and win32.<br>
<br>~M<br><br>[1]
I was able to get up and running with just a few hints from Vincent.
It literally took me less than an hour to create two tests, and this
was my first time creating *any* test for bzr. <br>
<br>[2] I have tentatively left the tests among the unittests, even though they *seem* like they belong with the blackbox tests. I did this because the bb tests seem to be command-specific (as strongly suggested in doc/developers/testing.txt) and I wanted to keep the wildcard matching tests all together in one place for now. I'm open to improvements, naturally.<br>
<br><br><div class="gmail_quote"> <br><br><br></div>