Comment perhaps needs to be nicer?

Aaron Bentley aaron at aaronbentley.com
Fri Sep 4 03:39:57 BST 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> 2009/9/3 Russel Winder <russel.winder at concertant.com>:
>> I just tried a commit but had not added the file so there was nothing to
>> commit.  The result was:
>>
>>        aborting commit write group: PointlessCommit(No changes to
>>        commit)
>>        bzr: ERROR: No changes to commit. Use --unchanged to commit
>>        anyhow.
>>
>> I am not entirely convinced that this is a good error message to emit in
>> this situation.
> 
> 1- showing the 'aborting write group' is a bit ugly but perhaps useful

I think it's not something we should be showing.  It makes aborts due to
empty commits, failed strictness checks and others look far worse than
they are, and exposes our internals.  I would be fine with showing it
when -Derror is used, but I don't think we should show it by default.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkqgffoACgkQ0F+nu1YWqI28VgCcChKWOSkeFYKfjmimpg1JTw53
xRoAn1zWUW5vB194zEgG34Ahcm7fJO1I
=7hxJ
-----END PGP SIGNATURE-----



More information about the bazaar mailing list