[RFD] Merge proposals and code reviews too private

Aaron Bentley aaron at aaronbentley.com
Thu Aug 20 07:07:22 BST 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Matthew D. Fuller wrote:
> On Thu, Aug 20, 2009 at 01:54:30AM -0400 I heard the voice of
> Aaron Bentley, and lo! it spake thus:
>> Code review was not designed for this.  Don't try to force it.  It
>> will break.
> 
> Quite possible.  But bzr's use of code review is.

Mainly, Bundle Buggy was tailored to bzr's existing code review process.

Code Review was designed to be a more general tool for projects that use
Launchpad, and designed to not require a mailing list.

If the Bazaar project wants to use a tool that wasn't designed
specifically for it, the project will have to adapt.

> We've been telling
> people for years that any suggested code be submitted to BB, and now
> Reviews, so that it's tracked, rather than just being a discussion
> thread.  We're already requiring that sort of usage of it.

I don't see how asking people to submit their code to a code review
system is inconsistent with code review being separate from the general
discussion list.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkqM6BcACgkQ0F+nu1YWqI16fgCbBqP7nYRsDP85Ve/2NikYnjm7
Bh8An3L/iAXtycp+U5SEoVXgl6ha3w9B
=jYYj
-----END PGP SIGNATURE-----



More information about the bazaar mailing list