Huge data transfers/bad performance on bzr pull??

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Thu, 2009-07-09 at 08:14 -0500, John Arbash Meinel wrote:
> 
> 
>> My guess is that this could be:
>>  4460 Canonical.com Patch Queue Manager	2009-06-18 [merge]
>>       (jam) Get rid of InterPackRepository in favor of PackStreamSource.
>>
>> Which isn't in 1.16.1, but will be in 1.17.
> 
> Do you mean 'caused by' or 'fixed by' 4460 ?
> 
> IPR knows how to filter down to revs and shouldn't be copying full packs
> - it is possible there is a bug in there. I'd be more inclined to blame
> InterDifferingSerializer though, which will do terrible things to a high
> latency or bandwidth constrained situation.
> 
> -Rob

"fixed by"

IPR was changed to always fetch the full set of texts referenced by the
inventories being copied.

It was *not* updated to filter out the set of texts referenced by parent
inventories.

Thus if you got a fulltext inventory, it would fetch the keys for the
entire tree.

When I went to fix this, instead of updating IPR, I chose to just write
a new StreamSource because that seemed to be the route we were going.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpWqpwACgkQJdeBCYSNAAMXBACdFuk5nEjb6OYk3Wdqg7lYZKgg
8DYAoI5bbJayOr5ngDD6EujocVipTsU0
=kUIG
-----END PGP SIGNATURE-----