[qbzr] Re: [qbzr/bzr-gtk] Save commit message and other metadata when commit GUI dialog is cancelled or in uncommit hook
Vincent Ladeuil
v.ladeuil+lp at free.fr
Thu Jun 18 13:30:50 BST 2009
>>>>> "bialix" == Alexander Belchenko <bialix at ukr.net> writes:
<snip/>
Gary> The save on cancel would then be a separate code path
Gary> :-(
>>
>> It complicates code (separate code path), it complicates
>> UI (use aborted commit info or uncommit one), but damn, it
>> sounds so much cleaner !
bialix> We can (and perhaps should) save both message(s) and
bialix> revids on uncommit. And save revid=None for canceled
bialix> commit. Then we can avoid 2 separate code
bialix> paths. N'est pas?
Sure, that's certainly a good idea, but I think Garry's idea was
to save the revid only on uncommit to avoid saving the message.
Vincent
More information about the bazaar
mailing list