[qbzr] Re: [qbzr/bzr-gtk] Save commit message and other metadata when commit GUI dialog is cancelled or in uncommit hook

Alexander Belchenko bialix at ukr.net
Wed Jun 17 17:16:23 BST 2009


Vincent Ladeuil пишет:
>>>>>> "Gary" == Gary van der Merwe <garyvdm at gmail.com> writes:
> 
> <snip/>
> 
>     Gary> For uncommit, it might be better to save just the
>     Gary> revid(s). Then the dialog can load all the information
>     Gary> that it needs by loading these revisions.
> 
>     Gary> The save on cancel would then be a separate code path
>     Gary> :-(
> 
> It complicates code (separate code path), it complicates UI (use
> aborted commit info or uncommit one), but damn, it sounds so much
> cleaner !

We can (and perhaps should) save both message(s) and revids on uncommit.
And save revid=None for canceled commit. Then we can avoid 2 separate 
code paths. N'est pas?



More information about the bazaar mailing list