[rfc] time to switch to Launchpad reviews

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> Martin Pool wrote:
>> Any comments, particularly from people who're participating in
>> development or review at the moment?
> 
> I think Launchpad code reviews and Bundle Buggy are (at last) in a state
> where both are reasonable choices.
> 
> Code Review's advantages
> - Submitters can request particular reviewers
> - Integrated with Launchpad
>  - Can use LP teams
>  - Can create a branch on Launchpad from an emailed merge directive
>  - Planned: provide an alternative mechanism for landing patches
> - Provides a virtual mailing list and web forum for each submission
> - Optional Merge Analysis Daemon can provide preview diffs that detect
>   merge conflicts
> - More reliable
^- As in, Launchpad doesn't crash as often? Do we know if the email
interface gets as easily confused as the bug submission one? (I often
have new at bugs... give me failure bounces because I get some sort of
syntax wrong.)

  - Doesn't require subscribing to bzr.dev to join in the discussion

> 
> Bundle Buggy advantages
> - Maps tightly to Bazaar project's workflow
>  - merge request status is determined fully automatically
>  - no need for public branches
> - Can represent a cherrypick (e.g. submitting multiple threads from a
>   loom in parallel)
> - Integrates cleanly with existing mailing lists
> - Accepts patches
> - Nicer email command syntax
> - Autodetection of superseded merge requests

 - Provides a nice 'this patch has landed' message
 - Already sorts into my 'bzr' folder because the mail goes to the same
   list. I tried looking at the headers and found:

X-Launchpad-Project: bzr
^- Might be enough to sort on, though I'm guessing

Reply-To: mp+5861 at code.launchpad.net
Message-Id: <20090424134019.14170.96598.launchpad at loganberry.canonical.com>
X-Launchpad-Message-Rationale: Subscriber @bzr
X-Launchpad-Branch: ~bzr/bzr/trunk
^- again a maybe, doesn't seem particularly great (mabye everything in
X-Launchpad-Branch:.*/bzr/.* ?

To: John A Meinel <john at arbash-meinel.com>
^- All emails from LP are sent *directly* to me, and not to a generic
group (~bzr).

From: Martin Pool <mbp at sourcefrog.net>
Subject: [Merge] lp:~mbp/bzr/trivial into lp:bzr
Date: Fri, 24 Apr 2009 13:40:20 -0000
Sender: bounces at canonical.com
Errors-To: bounces at canonical.com
Precedence: bulk
X-Generated-By: Launchpad (canonical.com); Revision="None";
	Instance="initZopeless config overlay"
X-Launchpad-Hash: 8d8e83a2600976390b169db6cfb0548b267db341

^- Not much here to filter on.

Any ideas?

John
=:->



> 
> Code reviews finally support converting bundles into branches, which I
> felt was a major missing piece.  Unfortunately, it will silently discard
> merge directives whose target URL has a trailing slash:
> https://bugs.launchpad.net/launchpad-bazaar/+bug/318040
> 
>> If there are no blockers I propose that we change the standard
>> practice to posting merge proposals rather than to BB, leave BB
>> running as a backup, and then if that goes well change the normal
>> practice across.
> 
> I don't understand the difference between the "change the standard
> practice" part and the "change the normal practice" part.
> 
> Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAknx4SgACgkQJdeBCYSNAANnYACgw+WNNvgEMWIWdAGz8TIE6iRm
y8AAniWwqVTxYA5KW+vebop4VHnEfno9
=DDkk
-----END PGP SIGNATURE-----