[MERGE][#346998] Fix MAPI send to email addresses

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Neil Martinsen-Burrell wrote:
> John caught a regression against 1.12 in MAPIClient when trying to send
> to an email address.  The body parameter was not being properly
> propagated.  The attached (trivial) fix solves the problem.

It fixes it at the expense of backwards compatibility, by causing
ExternalMailClient (which derives from BodyExternalMailClient) to supply
a body parameter to clients that don't support it.

A better approach would be to make the body parameter of MAPIClient
optional.

> I have not
> reduced the test coverage because there was none to begin with (hence
> the regression) but I wasn't able to imagine a reasonable way to test
> interaction with an external program, much less an external protocol. It
> appears that MAPIClient is completely untested.

Yes, I have the same problem.  Unfortunately, that lack of testability
caused this regression to happen.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkngm4gACgkQ0F+nu1YWqI1a+wCdGNLzdhdQ8UFBfOmNcdGCiYBV
oNEAn1CxIfO6IvnSuZLNeIwTviuSk1wt
=LbbZ
-----END PGP SIGNATURE-----