Last day to vote/reject on proposed EOL names

Stephen J. Turnbull stephen at xemacs.org
Tue Mar 31 18:54:12 BST 2009


Ian Clatworthy writes:

 > So my point is this: content filters are a read/write pair and
 > these pairs need to DTRT. I can't see how they can if we're using
 > tree-eol to set the write filter and repo-eol to set the read filter.

Indeed.  The issue is that correct filter behavior depends on *both*
the source format and the target format.  So:

def select_write_filter(tree_eol, repo_eol):
    # DTRT

def select_read_filter(tree_eol, repo_eol):
    # DTRT

Also, repo_eol should have a fixed value, one of lf, cr, or crlf.  It
should never be native, and it should only be "exact" while
autodetecting a file during branch conversion.  After that, of course,
it will be whatever the file was detected as (which might in fact be
"binary" if multiple eol conventions were found).



More information about the bazaar mailing list