[MERGE] Repository.iter_files_bytes()

Robert Collins robert.collins at canonical.com
Wed Mar 25 22:25:19 GMT 2009


On Wed, 2009-03-25 at 14:16 -0400, Aaron Bentley wrote:
> 
> > === modified file 'bzrlib/revisiontree.py'
> > --- bzrlib/revisiontree.py    2009-03-23 14:59:43 +0000
> > +++ bzrlib/revisiontree.py    2009-03-25 16:27:34 +0000
> > @@ -64,7 +64,8 @@
> >          return self._revision_id
> >  
> >      def get_file_text(self, file_id, path=None):
> > -        return list(self.iter_files_bytes([(file_id, None)]))[0][1]
> > +        _, content = list(self.iter_files_bytes([(file_id,
> None)]))[0]
> 
> I would prefer not to use underscore this way, but I guess there's
> already precedent in the codebase.

FWIW, I recall seeing comments from Guido that this is approriate.

-Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090326/c6fa450f/attachment.pgp 


More information about the bazaar mailing list