[MERGE] Repository.iter_files_bytes()

Alexander Belchenko bialix at ukr.net
Thu Mar 26 04:40:49 GMT 2009


Robert Collins пишет:
> On Wed, 2009-03-25 at 14:16 -0400, Aaron Bentley wrote:
>>> === modified file 'bzrlib/revisiontree.py'
>>> --- bzrlib/revisiontree.py    2009-03-23 14:59:43 +0000
>>> +++ bzrlib/revisiontree.py    2009-03-25 16:27:34 +0000
>>> @@ -64,7 +64,8 @@
>>>          return self._revision_id
>>>  
>>>      def get_file_text(self, file_id, path=None):
>>> -        return list(self.iter_files_bytes([(file_id, None)]))[0][1]
>>> +        _, content = list(self.iter_files_bytes([(file_id,
>> None)]))[0]
>>
>> I would prefer not to use underscore this way, but I guess there's
>> already precedent in the codebase.
> 
> FWIW, I recall seeing comments from Guido that this is approriate.

The _ interacts horribly with pdb and gettext.

> 
> -Rob




More information about the bazaar mailing list