[MERGE] Repository.iter_files_bytes()

Aaron Bentley aaron at aaronbentley.com
Wed Mar 25 18:16:24 GMT 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> This changes iter_files_bytes() to return a chunked string, which is
> what the api was defined as in the first place.

Nice!

> === modified file 'bzrlib/revisiontree.py'
> --- bzrlib/revisiontree.py	2009-03-23 14:59:43 +0000
> +++ bzrlib/revisiontree.py	2009-03-25 16:27:34 +0000
> @@ -64,7 +64,8 @@
>          return self._revision_id
>  
>      def get_file_text(self, file_id, path=None):
> -        return list(self.iter_files_bytes([(file_id, None)]))[0][1]
> +        _, content = list(self.iter_files_bytes([(file_id, None)]))[0]

I would prefer not to use underscore this way, but I guess there's
already precedent in the codebase.

bb:approve

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAknKdPUACgkQ0F+nu1YWqI0otACfT7e8WzpR98TMfxeAO30x2+qJ
5SkAn1PoeN3HssuKXIuri0RIArkJq32v
=nV7X
-----END PGP SIGNATURE-----



More information about the bazaar mailing list