[MERGE] Allow changing --[no-]trees with reconfigure (bug 145033)

Marius Kruger amanic at gmail.com
Sun Jan 18 19:55:45 GMT 2009

2009/1/9 Matthew D. Fuller <fullermd at over-yonder.net>

> One thing that came to mind in doing that was that this WILL do its
> thing if run on a branch in a shared repo (e.g., will change the
> repo's setting); it doesn't only work when in/pointed at the repo base
> itself.  I don't know if that could be construed as a problem, but I
> don't think it is.

Behold this is a problem: if it is runned within a branch&tree, it deletes
the workingtree!
I assume this it because of the values in reconfigure.Reconfigure:
    def set_repository_trees(klass, bzrdir, with_trees):
        """Convert a repository branch into a standalone branch"""
        reconfiguration = klass(bzrdir, with_trees=with_trees)
        reconfiguration._plan_changes(*want_tree=False, want_branch=False,

this is dangerous IMHO.
I think you should only allow running this directly in a repo (or when a
repo location is specified exactly).



btw, thanks a lot for working on this!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ubuntu.com/archives/bazaar/attachments/20090118/e57cafb5/attachment.htm 

More information about the bazaar mailing list