[MERGE] Allow changing --[no-]trees with reconfigure (bug 145033)
Ian Clatworthy
ian.clatworthy at internode.on.net
Fri Jan 9 04:11:26 GMT 2009
Matthew D. Fuller wrote:
> On Fri, Jan 09, 2009 at 10:58:23AM +1000 I heard the voice of
> Ian Clatworthy, and lo! it spake thus:
>> I think you need a test covering "reconfiguration not supported"
>> when used in a non-shared repo.
>>
>> Please add an item to NEWS as well, mentioning the bug and taking
>> the credit for fixing it.
>
> Added to blackbox tests and done.
Thanks.
> One thing that came to mind in doing that was that this WILL do its
> thing if run on a branch in a shared repo (e.g., will change the
> repo's setting); it doesn't only work when in/pointed at the repo base
> itself. I don't know if that could be construed as a problem, but I
> don't think it is.
I think that's fine.
bb:tweak
> + @classmethod
> + def set_repository_trees(klass, bzrdir, with_trees):
> + """Convert a repository branch into a standalone branch"""
Hmmm. That docstring was copied from the method above and is wrong.
It ought to be something like ...
"""Set/clear the trees flag on a repository."""
(To be tweaked during the merge to bzr.dev.)
Ian C.
More information about the bazaar
mailing list