<div class="gmail_quote">2009/1/9 Matthew D. Fuller <span dir="ltr"><<a href="mailto:fullermd@over-yonder.net">fullermd@over-yonder.net</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
One thing that came to mind in doing that was that this WILL do its<br>
thing if run on a branch in a shared repo (e.g., will change the<br>
repo's setting); it doesn't only work when in/pointed at the repo base<br>
itself. I don't know if that could be construed as a problem, but I<br>
don't think it is.</blockquote><div><br>Behold this is a problem: if it is runned within a branch&tree, it deletes the workingtree!<br>I assume this it because of the values in reconfigure.Reconfigure:<br> def set_repository_trees(klass, bzrdir, with_trees):<br>
"""Convert a repository branch into a standalone branch"""<br> reconfiguration = klass(bzrdir, with_trees=with_trees)<br> reconfiguration._plan_changes(<b>want_tree=False, want_branch=False,<br>
want_bound=False, want_reference=False,</b><br> want_shared_repository=True) <br><br></div></div>this is dangerous IMHO.<br>I think you should only allow running this directly in a repo (or when a repo location is specified exactly).<br>
<br>bb:resubmit<br><br>regards<br>marius<br><br>btw, thanks a lot for working on this!<br>