[MERGE] Support Claws as a mail client.

Aaron Bentley aaron at aaronbentley.com
Thu Jan 8 13:48:47 GMT 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Aaron Bentley wrote:
>> John Arbash Meinel wrote:
>>> The only other thing I might add to the test would be an actual
>>> non-ascii character to the "commandline_is_8bit" test. You could use
>>> something like u"\xb5" (aka µ).
> So instead you could have the test alonge the lines of:
> 
> subject = urllib.quote(str.encode(osutils.get_user_encoding(),
>                        'replace'))

Okay, I'll do that.

> Otherwise it sounds like it will fail if you have other encodings anyway.

If by 'fail' you mean "not include characters that can't be written at
the commandline".  But that was the designed behaviour.

> And I think if you use urllib.quote() we can make it work under any
> LANG, even one that gives iso-8859-1 (like LANG='en_US' rather than
> LANG='en_US.UTF-8').

I have no idea whether that would work.  URLs have no defined encoding--
the % encoding could well be interpreted according to the system locale,
not utf-8.  That's the behaviour I would expect,

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAklmBDoACgkQ0F+nu1YWqI3BWQCfWfyhciMbnhBakENjn0OjUMmq
4uIAnihKhRr6R0eqJSDm8pIOyoGaTiCK
=aIf1
-----END PGP SIGNATURE-----



More information about the bazaar mailing list