[MERGE] Support Claws as a mail client.

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> John Arbash Meinel wrote:
>> Aaron Bentley wrote:
>>> John Arbash Meinel wrote:
>>>> The only other thing I might add to the test would be an actual
>>>> non-ascii character to the "commandline_is_8bit" test. You could use
>>>> something like u"\xb5" (aka µ).
>> So instead you could have the test alonge the lines of:
> 
>> subject = urllib.quote(str.encode(osutils.get_user_encoding(),
>>                        'replace'))
> 
> Okay, I'll do that.
> 
>> Otherwise it sounds like it will fail if you have other encodings anyway.
> 
> If by 'fail' you mean "not include characters that can't be written at
> the commandline".  But that was the designed behaviour.

I mean that if you are using an iso-8859-1 locale, then the test will
fail because it will encode as %B5 instead of %3F (?) or %C2%B5 (the
utf-8 encoding).


> 
>> And I think if you use urllib.quote() we can make it work under any
>> LANG, even one that gives iso-8859-1 (like LANG='en_US' rather than
>> LANG='en_US.UTF-8').
> 
> I have no idea whether that would work.  URLs have no defined encoding--
> the % encoding could well be interpreted according to the system locale,
> not utf-8.  That's the behaviour I would expect,
> 
> Aaron

Right, I'm guessing that command line parameters are generally
interpreted wrt the system locale, but I don't know what *claws* does,
which is what we are trying to support here.

But we can merge whatever we want, and someone can come by later and say
whether it does/doesn't work for them on their locale, and we can fix it
at that point.

Thanks for landing it.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAklmHfgACgkQJdeBCYSNAAMB1wCgthAiyBFtzLZkbYbgPUbV2lAH
XfUAn1o+GbM4XvxaOFONe1Hn4PErAjS9
=9j6z
-----END PGP SIGNATURE-----