[MERGE] Support Claws as a mail client.
John Arbash Meinel
john at arbash-meinel.com
Thu Jan 8 02:05:17 GMT 2009
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Aaron Bentley wrote:
> John Arbash Meinel wrote:
>> The only other thing I might add to the test would be an actual
>> non-ascii character to the "commandline_is_8bit" test. You could use
>> something like u"\xb5" (aka µ).
...
> FAIL: test_mail_client.TestClaws.test_commandline_is_8bit
> not equal:
> a = ['--compose',
> 'mailto:jrandom at example.org?subject=%C2%B5cosm%20of%20fun%21',
> '--attach',
> 'file%']
> b = ['--compose',
> 'mailto:jrandom at example.org?subject=%3Fcosm%20of%20fun%21',
> '--attach',
> 'file%']
...
> As a result, I haven't been able to land it so far. How much do you
> want this?
>
> Aaron
So %3F == '?', which is probably because we have a
"unicode_str.encode(LANG, errors='replace')" somewhere in there.
So instead you could have the test alonge the lines of:
subject = urllib.quote(str.encode(osutils.get_user_encoding(),
'replace'))
Otherwise it sounds like it will fail if you have other encodings anyway.
And I think if you use urllib.quote() we can make it work under any
LANG, even one that gives iso-8859-1 (like LANG='en_US' rather than
LANG='en_US.UTF-8').
Thoughts?
I certainly still consider it worthwhile, though in the end it matters
mostly what *claws* would accept given a different LANG on the system.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkllX10ACgkQJdeBCYSNAAOVGwCgrPl6+ev9iynEAquaQ1xL31v7
iLsAoIsy6oaequ1zjaOA2FDZ+hkR4EAC
=nFC3
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list