[MERGE] BzrDir.backup_bzrdir()

[Jelmer Vernooij]

On Fri, 2008-12-05 at 07:28 -0600, John Arbash Meinel wrote:
> Jelmer Vernooij wrote:
> > The attached patch incorporates the suggestions from John for
> > backup_bzrdir.
> > 
> > Cheers,
> > 
> > Jelmer
> > 
> 
> Is there a reason you went with "backup_bzrdir()" instead of just
> "backup()" ?
> 
> It seems to me that you are doing something like:
> 
> bzrdir.backup()
> 
> So you don't really need the redundant
> 
> bzrdir.backup_bzrdir()
> 
> Also, I don't know what you named the SVN version, but
> svndir.backup_bzrdir() doesn't quite fit either.
> 
> The code looks fine, I just wonder about the name. (I'm opening this up
> for discussion, not saying you have to use my name.)
I went with backup_bzrdir() since there already is a retire_bzrdir()
function on BzrDir and it seemed like a good idea to be consistent with
that.

I agree svndir.backup_bzrdir() doesn't really fit, but the problem
mainly is that the class itself is actually called BzrDir.

Cheers,

Jelmer
-- 
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
Jabber: jelmer at jabber.fsfe.org