[MERGE] BzrDir.backup_bzrdir()

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jelmer Vernooij wrote:
> On Fri, 2008-12-05 at 07:28 -0600, John Arbash Meinel wrote:
>> Jelmer Vernooij wrote:
>>> The attached patch incorporates the suggestions from John for
>>> backup_bzrdir.
>>>
>>> Cheers,
>>>
>>> Jelmer
>>>
>> Is there a reason you went with "backup_bzrdir()" instead of just
>> "backup()" ?
>>
>> It seems to me that you are doing something like:
>>
>> bzrdir.backup()
>>
>> So you don't really need the redundant
>>
>> bzrdir.backup_bzrdir()
>>
>> Also, I don't know what you named the SVN version, but
>> svndir.backup_bzrdir() doesn't quite fit either.
>>
>> The code looks fine, I just wonder about the name. (I'm opening this up
>> for discussion, not saying you have to use my name.)
> I went with backup_bzrdir() since there already is a retire_bzrdir()
> function on BzrDir and it seemed like a good idea to be consistent with
> that.
> 
> I agree svndir.backup_bzrdir() doesn't really fit, but the problem
> mainly is that the class itself is actually called BzrDir.
> 
> Cheers,
> 
> Jelmer

I suppose you could call it ControlDir if you wanted to be a bit more
vcs agnostic.

I'll note that retire_bzrdir() is only called in one place, which is in
WT.subsume() (presumably called by the experimental 'bzr join' command).

Anyway, I'm okay with it, though I would personally prefer
"bzrdir.retire()" and "bzrdir.backup()". If you prefer backup_bzrdir()
you wrote the code, so you get to pick the naming.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkk5SpoACgkQJdeBCYSNAAM3QwCdEndXCB2/GjSjJLiHX0ZhTTOq
qRUAn0m8JcJ1CGfHoEzYje8Kg+Dydy8Z
=zgx9
-----END PGP SIGNATURE-----