[MERGE] BzrDir.backup_bzrdir()

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jelmer Vernooij wrote:
> The attached patch incorporates the suggestions from John for
> backup_bzrdir.
> 
> Cheers,
> 
> Jelmer
> 

Is there a reason you went with "backup_bzrdir()" instead of just
"backup()" ?

It seems to me that you are doing something like:

bzrdir.backup()

So you don't really need the redundant

bzrdir.backup_bzrdir()

Also, I don't know what you named the SVN version, but
svndir.backup_bzrdir() doesn't quite fit either.

The code looks fine, I just wonder about the name. (I'm opening this up
for discussion, not saying you have to use my name.)

John
=:->

BB:tweak
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkk5LJgACgkQJdeBCYSNAAORJgCgnHQzFRN1mnwpAVKO03g7awmv
9R8AmQFKqQ3DsgZ+mjY+T2N2vCTmNdYX
=AsPl
-----END PGP SIGNATURE-----