[MERGE] (Trivial) Fix missing dependency check for paramiko.

[Vincent Ladeuil]

>>>>> "Andrew" == Andrew Bennetts <andrew.bennetts at canonical.com> writes:

    Andrew> Vincent Ladeuil wrote:
    >> Found while testing non-regression for python-2.6 and OSX.

    Andrew> [...]
    >> === modified file 'bzrlib/tests/test_sftp_transport.py'
    >> --- bzrlib/tests/test_sftp_transport.py	2008-11-07 05:39:09 +0000
    >> +++ bzrlib/tests/test_sftp_transport.py	2008-11-26 16:58:21 +0000
    >> @@ -497,6 +497,8 @@
    >> (42000, 24000)])
    >> 
    >> def checkRequestAndYield(self, expected, data, offsets):
    >> +        if not paramiko_loaded:
    >> +            raise TestSkipped('you must have paramiko to run this test')

    Andrew> bb:tweak

Sorry, it was already merged when I read this mail :-/

    Andrew> This is ok, in that it's consistent with the other
    Andrew> test in this test case.

    Andrew> Shouldn't we have a ParamikoFeature, so this could be
    Andrew> “self.requireFeature(ParamikoFeature)”?  Or even set
    Andrew> _test_needs_features = [ParamikoFeature] on the
    Andrew> TestCase.  It seems more useful to regard this as a
    Andrew> missing feature than a generic skip.

You're right, I just re-read test_sftp_transport.py and it's a
bit messy, I'll do a more thorough pass on it and submit a
follow-up patch, but no urgency here.

          Vincent