[MERGE] (Trivial) Fix missing dependency check for paramiko.
Andrew Bennetts
andrew.bennetts at canonical.com
Wed Nov 26 22:32:51 GMT 2008
Vincent Ladeuil wrote:
> Found while testing non-regression for python-2.6 and OSX.
[...]
> === modified file 'bzrlib/tests/test_sftp_transport.py'
> --- bzrlib/tests/test_sftp_transport.py 2008-11-07 05:39:09 +0000
> +++ bzrlib/tests/test_sftp_transport.py 2008-11-26 16:58:21 +0000
> @@ -497,6 +497,8 @@
> (42000, 24000)])
>
> def checkRequestAndYield(self, expected, data, offsets):
> + if not paramiko_loaded:
> + raise TestSkipped('you must have paramiko to run this test')
bb:tweak
This is ok, in that it's consistent with the other test in this test case.
Shouldn't we have a ParamikoFeature, so this could be
“self.requireFeature(ParamikoFeature)”? Or even set _test_needs_features =
[ParamikoFeature] on the TestCase. It seems more useful to regard this as a
missing feature than a generic skip.
-Andrew.
More information about the bazaar
mailing list