[MERGE][#299254] Fix RemoteTransport's translation of errors involving paths; it wasn't passing orig_path to _translate_error.

[Vincent Ladeuil]

Vincent Ladeuil has voted approve.
Status is now: Approved
Comment:
I'm not a big fan of error translation factorization because it makes it 
hard to refine diagnosis under some circumstances. But since this patch 
doesn't make that part worse, I think it should go in. And in that 
particular case, having a single point to translate the errors may be 
more appropriate than usual (since a serialization is involved anyway).

I also find a bit strange (not to say it violates some abstraction) that 
'orig_path' seems to pop out of nowhere but at least the comment 
explains that.

In a followup patch, you may want to review the other calls to 
_translate_error to make them more consistent (_readv for example 
doesn't pass relpath as a parameter and the parameter name itself is a 
bit unclear since path and orig_path are used in different places).


For details, see: 
http://bundlebuggy.aaronbentley.com/project/bzr/request/%3C20081120064828.GA6081%40steerpike.home.puzzling.org%3E
Project: Bazaar